Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pitch_entry_delete_nth_note.lua #663

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

jwink75
Copy link
Collaborator

@jwink75 jwink75 commented Jan 27, 2024

  • This script fulfills a request from Tim Davies for a way to quickly delete something like the 2nd or 3rd note in a chord. The script opens a dialog box to enter the note to be deleted (numbered from the top)
  • I also used the functions for keeping/deleting top/bottom notes from Nick Mazuk's scripts
  • Passes lint tests from the 'linting' PR

- This script fulfills a request from Tim Davies for a way to quickly delete something like the 2nd or 3rd note in a chord. The script opens a dialog box to enter the note to be deleted (numbered from the top)
- I also used the functions for keeping/deleting top/bottom notes from Nick Mazuk's scripts
- Passes lint tests from the 'linting' PR
@jwink75 jwink75 requested review from rpatters1 and asherber January 27, 2024 18:10
@cv-on-hub
Copy link
Contributor

I've also been pondering how to maximise the utility of Nick's keep/delete scripts. This proposal put me in mind of a neater solution. So forgive my presumption, but here's another option:
chord_note_keep_delete.lua.txt

@jwink75
Copy link
Collaborator Author

jwink75 commented Jan 30, 2024 via email

@cv-on-hub
Copy link
Contributor

Very glad that you enjoyed - and weren't offended! I think within this PR you just need to re-post my script as the latest "revision" of yours. (... and see how many revising co-authors get added to the list later...)

@cv-on-hub
Copy link
Contributor

Two extra key commands.
chord_note_keep_delete.lua.txt

@rpatters1
Copy link
Collaborator

I am a little confuse what chord_note_keep_delete.lua.txt is. It does not appear to be in the repo.

@asherber
Copy link
Member

Looks like it was uploaded here in the PR. I think the idea is that @jwink75 should download it, remove the txt extension, add it to his branch and delete his script, and push the commit. That will update this PR with @cv-on-hub's script.

@cv-on-hub
Copy link
Contributor

update this PR with @cv-on-hub's script.

And for repo purposes it should probably be named "pitch_entry_keep_delete.lua".

@asherber asherber closed this Jan 31, 2024
@asherber asherber reopened this Jan 31, 2024
@rpatters1 rpatters1 merged commit 8b43114 into finale-lua:master Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants